ENH Adds get_feature_names to isotonic module#22249
ENH Adds get_feature_names to isotonic module#22249ogrisel merged 6 commits intoscikit-learn:mainfrom
Conversation
Seems fine. Is there a reason why you don't use the |
I wanted to adjust the docstring for The alternative is to add support for
|
|
Thanks for the clarification. I don't really know what we should expect in the 1d case either. Maybe it's better to stick to your current workaround for now and come back to implementing n_features_in_ when we have a clear expectation. |
jeremiedbb
left a comment
There was a problem hiding this comment.
LGTM. Maybe add a comment on top of get_feature_names_out to quickly explain the need for re-implementing it here
Reference Issues/PRs
Towards #21308
What does this implement/fix? Explain your changes.
IsotonicRegressiononly supports 2d arrays with 1 feature and 1d arrays. In this case, I think we can haveget_feature_names_outalways return "isotonicregression0".Any other comments?
Note that the common tests does not run on
IsotonicRegressionbecause it has the{"X_types": ["1darray"]}tag.