Skip to content

ENH Adds get_feature_names to neural_network module#22248

Merged
lesteve merged 7 commits intoscikit-learn:mainfrom
thomasjpfan:neural_network_get_feature_names_out
Feb 4, 2022
Merged

ENH Adds get_feature_names to neural_network module#22248
lesteve merged 7 commits intoscikit-learn:mainfrom
thomasjpfan:neural_network_get_feature_names_out

Conversation

@thomasjpfan
Copy link
Copy Markdown
Member

Reference Issues/PRs

Towards #21308

What does this implement/fix? Explain your changes.

There is only one transformer in the neural_network module.

Copy link
Copy Markdown
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @thomasjpfan

Copy link
Copy Markdown
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lesteve
Copy link
Copy Markdown
Member

lesteve commented Feb 4, 2022

Merging this one since there are two approvals already!

@lesteve lesteve merged commit 00a39a3 into scikit-learn:main Feb 4, 2022
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants