ENH Adds get_feature_names_out for AdditiveChi2Sampler#22137
Merged
jeremiedbb merged 8 commits intoscikit-learn:mainfrom Mar 8, 2022
Merged
ENH Adds get_feature_names_out for AdditiveChi2Sampler#22137jeremiedbb merged 8 commits intoscikit-learn:mainfrom
jeremiedbb merged 8 commits intoscikit-learn:mainfrom
Conversation
ogrisel
reviewed
Jan 14, 2022
Member
ogrisel
left a comment
ogrisel
left a comment
There was a problem hiding this comment.
LGTM. The output feature names are actually very informative for this transformer. Just a comment on the changelog:
Co-authored-by: Olivier Grisel <[email protected]>
14 tasks
ogrisel
approved these changes
Mar 7, 2022
jeremiedbb
approved these changes
Mar 8, 2022
Member
jeremiedbb
left a comment
jeremiedbb
left a comment
There was a problem hiding this comment.
I directly resolved the conflicts from merging #22694 first. LGTM. Thanks @thomasjpfan !
thomasjpfan
added a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Mar 8, 2022
…22137) Co-authored-by: Olivier Grisel <[email protected]> Co-authored-by: Jérémie du Boisberranger <[email protected]>
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Apr 6, 2022
…22137) Co-authored-by: Olivier Grisel <[email protected]> Co-authored-by: Jérémie du Boisberranger <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #21308
What does this implement/fix? Explain your changes.
This PR is adds
get_feature_names_outforAdditiveChi2Sampler. This is it's own PR because the generated names are specific to this transformer.Any other comments?
Docstring for
transformis incorrect. I opened #22138 as a quick docstring fix.The
test_transformers_get_feature_names_outcommon tests will run onAdditiveChi2Samplerbecause it definesget_feature_names_outin this PR.scikit-learn/sklearn/tests/test_common.py
Lines 394 to 396 in 1c24595