Skip to content

ENH Adds get_feature_names_out for discriminant_analysis#22120

Merged
glemaitre merged 2 commits intoscikit-learn:mainfrom
thomasjpfan:discriminant_analysis_feature_names_out
Jan 4, 2022
Merged

ENH Adds get_feature_names_out for discriminant_analysis#22120
glemaitre merged 2 commits intoscikit-learn:mainfrom
thomasjpfan:discriminant_analysis_feature_names_out

Conversation

@thomasjpfan
Copy link
Copy Markdown
Member

Reference Issues/PRs

Address a part of #21308

What does this implement/fix? Explain your changes.

This PR add get_feature_names_out to discriminant_analysis estimators.

Copy link
Copy Markdown
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@glemaitre glemaitre merged commit 5c67518 into scikit-learn:main Jan 4, 2022
@glemaitre
Copy link
Copy Markdown
Member

Thanks @thomasjpfan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants