ENH Adds get_feature_names_out for cross_decomposition#22119
Merged
glemaitre merged 4 commits intoscikit-learn:mainfrom Jan 4, 2022
Merged
ENH Adds get_feature_names_out for cross_decomposition#22119glemaitre merged 4 commits intoscikit-learn:mainfrom
glemaitre merged 4 commits intoscikit-learn:mainfrom
Conversation
14 tasks
thomasjpfan
changed the title
ogrisel
approved these changes
Jan 3, 2022
| [f"{class_name_lower}{i}" for i in range(est.x_weights_.shape[1])], | ||
| dtype=object, | ||
| ) | ||
| assert_array_equal(names_out, expected_names_out) |
Member
There was a problem hiding this comment.
Maybe those tests could be extended to also assert that est.transform(X[:1]).shape[1] == expected_names_out.shape[0].
Member
Author
There was a problem hiding this comment.
The proposed check is in the common tests:
scikit-learn/sklearn/utils/estimator_checks.py
Lines 3954 to 3956 in 42a34e8
Member
There was a problem hiding this comment.
Actually this is already tested in the common test.
glemaitre
approved these changes
Jan 4, 2022
Member
glemaitre
left a comment
glemaitre
left a comment
There was a problem hiding this comment.
I solved the conflicts and I will merge once the CIs are green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Address a part of #21308
What does this implement/fix? Explain your changes.
This PR add
get_feature_names_outtocross_decompositionestimators.