FIX Fixes joblib memmap error for KDTree and BallTree #21845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjerphan
approved these changes
Dec 1, 2021
Member
jjerphan
left a comment
jjerphan
left a comment
There was a problem hiding this comment.
LGTM after treating suggestions.
Thank you for working on this, @thomasjpfan; I am currently busy with other tasks.
ogrisel
reviewed
Dec 1, 2021
ogrisel
approved these changes
Dec 1, 2021
Member
ogrisel
left a comment
ogrisel
left a comment
There was a problem hiding this comment.
LGTM as well. I confirm the non-regression test would fail in main and now passes with this PR.
Member
|
I pushed 9b173be to fix the linter and get a full CI run. |
thomasjpfan
commented
Dec 1, 2021
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Dec 24, 2021
…1845) Co-authored-by: Olivier Grisel <[email protected]>
glemaitre
pushed a commit
that referenced
this pull request
Dec 25, 2021
Co-authored-by: Olivier Grisel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #21685
What does this implement/fix? Explain your changes.
This PR forces the memoryview attributes to be constant.
node_datais created to be writable ndarray in__init__and is populated when_recursive_buildis called._recursive_buildis only called in__init__. Afterwards__init__,node_datanot no longer modified.CC @jjerphan