ENH Adds feature names out to decomposition module#21334
Merged
adrinjalali merged 8 commits intoscikit-learn:mainfrom Oct 27, 2021
Merged
ENH Adds feature names out to decomposition module#21334adrinjalali merged 8 commits intoscikit-learn:mainfrom
adrinjalali merged 8 commits intoscikit-learn:mainfrom
Conversation
github-actions
bot
added
module:decomposition
module:feature_extraction
module:utils
labels
14 tasks
Member
|
What do you think of having the |
Member
Author
I didn't want to introduce a public API into this PR. If we go the mixin direction, I think we can go with a private |
adrinjalali
approved these changes
Oct 25, 2021
Member
|
whats_new confligt, otherwise LGTM. |
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
* ENH Adds feature names out to decomposition module * DOC Adds whats enw * REV Removes module not in decomposition * ENH Uses a mixin * REV Better merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses some of #21308
What does this implement/fix? Explain your changes.
This PR adds a
_generate_get_feature_names_outthat can be used by estimators that generate their own names.