MAINT Removes assert_warns in test_estimator_checks #20518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
force-pushed
the
assert_warns_removal
branch
from
f5e6e0a to
dbf59be
Compare
ogrisel
approved these changes
Jul 13, 2021
| assert_warns(SkipTestWarning, check_estimator, NuSVC()) | ||
| with warnings.catch_warnings(record=True) as records: | ||
| check_estimator(NuSVC()) | ||
| assert SkipTestWarning in [rec.category for rec in records] |
Member
There was a problem hiding this comment.
with pytest.warns does not work in this case? Why? It's special cased in pytest?
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19414