DOC Ensures numpydoc validation for CountVectorizer and TfidfVectorizer/Transformer #20403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
reviewed
Jun 27, 2021
Member
thomasjpfan
left a comment
thomasjpfan
left a comment
There was a problem hiding this comment.
Thank you for the PR @joaovitormascarenhas !
There are still remaining validation errors. You can see them on the CI through this link (and scroll up): https://dev.azure.com/scikit-learn/scikit-learn/_build/results?buildId=29895&view=logs&j=78a0bf4f-79e5-5387-94ec-13e67d216d6e&t=dbc16e8a-e84c-5cb6-14f6-590d872d6e0b
glemaitre
changed the title
glemaitre
requested changes
Jun 28, 2021
glemaitre
changed the title
Member
|
All good. Thanks @joaovitormascarenhas |
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
…er/Transformer (scikit-learn#20403) Co-authored-by: Joao Vitor Mascarenhas <[email protected]> Co-authored-by: Guillaume Lemaitre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#20308
What does this implement/fix? Explain your changes.
This fixes the documentation of the class.
Any other comments?
#DataUmbrella sprint
cc: @joaovitormascarenhas @GabrielBernardoMC