DOC Ensures that PoissonRegressor passes numpydoc validation #20386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
approved these changes
Jun 26, 2021
Member
glemaitre
left a comment
glemaitre
left a comment
There was a problem hiding this comment.
LGTM. Let see if the CIs catch something else.
glemaitre
reviewed
Jun 28, 2021
glemaitre
reviewed
Jun 28, 2021
Member
|
I made a small change on the property to see if we can write a more condensed way the property. |
Contributor
Author
|
Thanks, @glemaitre. Should we change anything else? |
glemaitre
approved these changes
Jul 6, 2021
Member
glemaitre
left a comment
glemaitre
left a comment
There was a problem hiding this comment.
I merge main into your branch. If the CIs agree, we will be merging afterwards.
glemaitre
reviewed
Jul 7, 2021
Member
|
OK so we will omit the type to pass the validation. If the type is a complex type as |
glemaitre
approved these changes
Jul 7, 2021
Member
glemaitre
left a comment
glemaitre
left a comment
There was a problem hiding this comment.
I merge main into the branch, it should solve the issue with the doc CI.
Member
|
OK so this is good. Thanks @lacouth |
thomasjpfan
pushed a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Jul 7, 2021
…learn#20386) Co-authored-by: Guillaume Lemaitre <[email protected]>
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
…learn#20386) Co-authored-by: Guillaume Lemaitre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#DataUmbrella sprint
Reference Issues/PRs
Adresses #20308
cc.: @gitdoluquita pair programming partner
Removing PoissonRegressor from DOCSTRING_IGNORE_LIST
Fixing numpydoc errors in PoissonRegressor class, fit method and family property.
Any other comments?
We are not sure if the property is documented in the right way.