DOC Ensures that LogisticRegression passes numpydoc validation #20370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
approved these changes
Jun 26, 2021
Member
glemaitre
left a comment
glemaitre
left a comment
There was a problem hiding this comment.
LGTM. I run the test locally and it passes.
We will wait for the CIs to agree just to be sure.
Member
|
Thanks @lacouth All good. |
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#DataUmbrella sprint
Reference Issues/PRs
Adresses #20308
cc.: @gitdoluquita pair programming partner
What does this implement/fix? Explain your changes.
Removing LogisticRegression from DOCSTRING_IGNORE_LIST
Any other comments?
All tests already passed