Skip to content

Conversation

@nanshanli
Copy link
Contributor

@nanshanli nanshanli commented Jun 8, 2021

Reference Issues/PRs

Towards #19333

What does this implement/fix? Explain your changes.

Add n_features_in_ attribute to docstrings in cluster.

Any other comments?

From what I can tell, there are no other existing attributes (such as n_features_) which have to be deprecated in the docstrings. Let me know if this is right and I can continue working on the other modules.

Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lesteve
Copy link
Member

lesteve commented Jun 9, 2021

Merging thanks!

@lesteve lesteve merged commit 45fc4b7 into scikit-learn:main Jun 9, 2021
@TomDLT TomDLT mentioned this pull request Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants