Skip to content

TST common tests for n_features_in_ for model_selection module #20204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ogrisel merged 9 commits into from
Jun 15, 2021
Merged

TST common tests for n_features_in_ for model_selection module #20204

ogrisel merged 9 commits into from
Jun 15, 2021

Conversation

@glemaitre
Copy link
Member

@glemaitre glemaitre commented Jun 3, 2021

Toward #19333

@glemaitre glemaitre mentioned this pull request Jun 9, 2021
Closed
47 tasks
ogrisel
ogrisel approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (assuming green CI).

jeremiedbb
jeremiedbb approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

@ogrisel ogrisel merged commit 05319e7 into scikit-learn:main Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ogrisel ogrisel ogrisel approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees

No one assigned

Labels

module:model_selection No Changelog Needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@glemaitre @ogrisel @jeremiedbb