FIX Fix RandomForestRegressor doesn't accept max_samples=1.0 #20156 #20159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
reviewed
May 28, 2021
Member
ogrisel
left a comment
ogrisel
left a comment
There was a problem hiding this comment.
Thanks, this looks good. Could you please add a test to check that this edge is accepted? Test that the result of:
RandomForestRegressor(max_samples=1.0, random_state=0).fit(X_train, y_train).predict_proba(X_test)is the same:
RandomForestRegressor(max_samples=None, random_state=0).fit(X_train, y_train).predict_proba(X_test)
ogrisel
reviewed
May 28, 2021
Member
|
Thanks @murata-yu ! Please add a what's new entry. |
Contributor
Author
|
Hi, there. I add tests on 3f8a2a6. I have some questions to discuss.
|
Member
Yes!
I think the test names are fine. |
ogrisel
reviewed
May 31, 2021
Member
ogrisel
left a comment
ogrisel
left a comment
There was a problem hiding this comment.
LGTM. Just a small comment. Also please document the change in doc/whats_new/v1.0.rst.
Contributor
Author
|
I documented the change in |
cmarmo
reviewed
Jun 1, 2021
Contributor
cmarmo
left a comment
cmarmo
left a comment
There was a problem hiding this comment.
Hi @murata-yu , sphinx is complaining about the syntax in the what's new file. This will fix the warning. Thanks for your work so far.
ogrisel
reviewed
Jun 1, 2021
Co-authored-by: Olivier Grisel <[email protected]>
ogrisel
reviewed
Jun 1, 2021
Co-authored-by: Olivier Grisel <[email protected]>
ogrisel
reviewed
Jun 1, 2021
ogrisel
approved these changes
Jun 1, 2021
Member
ogrisel
left a comment
ogrisel
left a comment
There was a problem hiding this comment.
Besides the above comment, LGTM. Thank you very much for the PR!
ogrisel
reviewed
Jun 1, 2021
thomasjpfan
reviewed
Jun 3, 2021
Member
thomasjpfan
left a comment
thomasjpfan
left a comment
There was a problem hiding this comment.
Thank you for the PR @murata-yu !
Co-authored-by: Thomas J. Fan <[email protected]>
Co-authored-by: Thomas J. Fan <[email protected]>
Co-authored-by: Thomas J. Fan <[email protected]>
Co-authored-by: Thomas J. Fan <[email protected]>
Co-authored-by: Thomas J. Fan <[email protected]>
Co-authored-by: Thomas J. Fan <[email protected]>
thomasjpfan
approved these changes
Jun 4, 2021
Member
thomasjpfan
left a comment
thomasjpfan
left a comment
There was a problem hiding this comment.
Thank you for the updates @murata-yu !
I left a small comment regarding the whats new. Otherwise this PR looks good to me.
thomasjpfan
changed the title
Co-authored-by: Thomas J. Fan <[email protected]>
thomasjpfan
added a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Jun 8, 2021
* TST enable test docstring params for feature extraction module (scikit-learn#20188) * DOC fix a reference in sklearn.ensemble.GradientBoostingRegressor (scikit-learn#20198) * FIX mcc zero divsion (scikit-learn#19977) * TST Add TransformedTargetRegressor to test_meta_estimators_delegate_data_validation (scikit-learn#20175) Co-authored-by: Guillaume Lemaitre <[email protected]> * TST enable n_feature_in_ test for feature_extraction module * FIX Uses points instead of pixels in plot_tree (scikit-learn#20023) * MNT n_features_in through the multiclass module (scikit-learn#20193) * CI Removes python 3.6 builds from wheel building (scikit-learn#20184) * FIX Fix typo in error message in `fetch_openml` (scikit-learn#20201) * FIX Fix error when using Calibrated with Voting (scikit-learn#20087) * FIX Fix RandomForestRegressor doesn't accept max_samples=1.0 (scikit-learn#20159) Co-authored-by: Olivier Grisel <[email protected]> Co-authored-by: Thomas J. Fan <[email protected]> * ENH Adds Poisson criterion in RandomForestRegressor (scikit-learn#19836) Co-authored-by: Christian Lorentzen <[email protected]> Co-authored-by: Alihan Zihna <[email protected]> Co-authored-by: Alihan Zihna <[email protected]> Co-authored-by: Chiara Marmo <[email protected]> Co-authored-by: Olivier Grisel <[email protected]> Co-authored-by: naozin555 <[email protected]> Co-authored-by: Venkatachalam N <[email protected]> Co-authored-by: Thomas J. Fan <[email protected]> * TST Replace assert_warns from decomposition/tests (scikit-learn#20214) * TST check n_features_in_ in pipeline module (scikit-learn#20192) Co-authored-by: Olivier Grisel <[email protected]> Co-authored-by: Jérémie du Boisberranger <[email protected]> Co-authored-by: Olivier Grisel <[email protected]> * Allow `n_knots=None` if knots are explicitly specified in `SplineTransformer` (scikit-learn#20191) Co-authored-by: Olivier Grisel <[email protected]> * FIX make check_complex_data deterministic (scikit-learn#20221) * TST test_fit_docstring_attributes include properties (scikit-learn#20190) * FIX Uses the color max for colormap in ConfusionMatrixDisplay (scikit-learn#19784) * STY Changing .format method to f-string formatting (scikit-learn#20215) * CI Adds permissions for label action Co-authored-by: Jérémie du Boisberranger <[email protected]> Co-authored-by: tsuga <[email protected]> Co-authored-by: Conner Shen <[email protected]> Co-authored-by: Guillaume Lemaitre <[email protected]> Co-authored-by: mlondschien <[email protected]> Co-authored-by: Clément Fauchereau <[email protected]> Co-authored-by: murata-yu <[email protected]> Co-authored-by: Olivier Grisel <[email protected]> Co-authored-by: Brian Sun <[email protected]> Co-authored-by: Christian Lorentzen <[email protected]> Co-authored-by: Alihan Zihna <[email protected]> Co-authored-by: Alihan Zihna <[email protected]> Co-authored-by: Chiara Marmo <[email protected]> Co-authored-by: Olivier Grisel <[email protected]> Co-authored-by: naozin555 <[email protected]> Co-authored-by: Venkatachalam N <[email protected]> Co-authored-by: Nanshan Li <[email protected]> Co-authored-by: solosilence <[email protected]>
54 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #20156
What does this implement/fix? Explain your changes.
fix
max_samplesrange for (0, 1) to (0, 1]Any other comments?