ENH store per-transformer index into feature space in FeatureUnion#1952
Closed
jnothman wants to merge 1 commit intoscikit-learn:masterfrom
Closed
ENH store per-transformer index into feature space in FeatureUnion#1952jnothman wants to merge 1 commit intoscikit-learn:masterfrom
jnothman wants to merge 1 commit intoscikit-learn:masterfrom
Conversation
Member
Author
|
Closing due to lack of interest and underspecification. |
Member
Author
|
I reckon this kind of thing is still worth having. I intend to resurrect it. I still don't have a certain solution for the |
This was referenced Jul 10, 2018
3 tasks
Member
|
Since having |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FeatureUnionprovided no simple way to tell which parts of the stack belonged to which transformer. This provides afeature_ptr_attribute (of the form ofcsr_matrix.indptr) to solve that.Caveats:
fit_transform, notfit, is calledtransformtime without a refit.Both these caveats would be solved if each transformer in sklearn provided a way to get the number of output features. I suggest a
transformed_width_attribute orget_transformed_width()method (better name?), the latter making it more clear that the output can be affected byset_params. I also suggest this be posed as an Easy Issue for someone to tackle.Finally,
feature_ptr_is compact and versatile, but it might be more usable if I add a method to get this data as a dict from transformer-name toslices.