Skip to content

Conversation

@TwsThomas
Copy link
Contributor

@TwsThomas TwsThomas commented Sep 29, 2020

What does this implement/fix? Explain your changes.

Allow dict_learning_online to handles nan

todo

  • add tests
  • add minibatch
  • documentation
  • support custom missing value marker
  • partial fit
  • transform
  • write an example

Any other comments?

Adapted from "Online Group-Structured Dictionary Learning " by Z. Szabo, B. Poczos, A. Lörnicz, 2011

The benchmarks are as follow:
The execution time of dict_learning_na is similar on small dataset w.r.t. dict_learning_online
time

The loss is also comparable to dict_learning_online
loss

The reconstruction of missing values is compared with KNN, SoftImpute and IterativeSVD from fancyimpute. On the digits dataset
digits_reconstruction

@GaelVaroquaux GaelVaroquaux changed the title [WIP] handles Nan in dict learning online [WIP] online matrix factorization with missing values Oct 1, 2020
@adrinjalali
Copy link
Member

superseded by #25356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants