API Implements get_feature_names_out for transformers that support get_feature_names by thomasjpfan · Pull Request #18444 · scikit-learn/scikit-learn

thomasjpfan · 2020-09-23T19:22:44Z

Reference Issues/PRs

Fixes #6425
Closes #12627
Follows up on: #18010

What does this implement/fix? Explain your changes.

This PR adds:

get_feature_names_out in transformers that have get_feature_names. This was motivated by Feature names with input features #13307 (comment). The signature of get_output_names is always get_output_names(input_features=None) where input_features can be ignored.
get_feature_names is deprecated.
The output of get_feature_names_out will be a list most of the time. The only case is when input_features is not None, and the transformer is one-to-one. I considered making this is a list, but I do not think it is worth the copy.

CC @amueller

…_feature_names

# Conflicts: # sklearn/base.py # sklearn/impute.py # sklearn/preprocessing/data.py

…into pipeline_get_feature_names

…it-learn into pipeline_get_feature_names

Co-authored-by: Olivier Grisel <[email protected]>

lorentzenchr

LGTM after a fast pass over the code. I'd love to have it in 1.0 in I dare taking the risk to push the green button....

thomasjpfan · 2021-09-06T17:18:29Z

My plan is to follow up this PR with adding get_feature_names_out to preprocessing and impute. I think that would cover a good percentage of the use cases. (Follow up PRs should be relatively simple to review)

lorentzenchr · 2021-09-06T17:19:58Z

@thomasjpfan Are you fine with merging now to have this PR in v1.0? (given CI is green)

ogrisel · 2021-09-06T17:23:43Z

@thomasjpfan Are you fine with merging now to have this PR in v1.0? (given CI is green)

@adrinjalali has already branched 1.0.X. Maybe it's too late.

I don't mind having this in 1.1.0, hopefully that will be a good motivation to not wait too long to release 1.1 :)

I let @adrinjalali decide on the fate of this PR. Based on his decision, we will have to update the what's new entry before merging.

lorentzenchr · 2021-09-06T17:25:52Z

There is a CI failure anyway.

adrinjalali · 2021-09-06T19:36:35Z

I still haven't tagged, I'm happy to include this if it gets merged by tomorrow

thomasjpfan · 2021-09-06T21:08:52Z

I recently opened #20919 that enabled TfidfTransformer to run with common tests, which made this PR fail.

My fix is in 560c0d0. Since TfidfTransformer is a "one-to-one" transformer, I added a mixin that adds get_feature_names_out for one-to-one transformers. The commit also adds get_features_names_out to transformers that also have this "one-to-one" correspondence.

ogrisel · 2021-09-07T08:57:48Z

I merged then! Thanks very much @thomasjpfan!

@adrinjalali this will need a backport to 1.0.X.

…t_feature_names (#18444) Co-authored-by: Andreas Mueller <[email protected]> Co-authored-by: Andreas Mueller <[email protected]> Co-authored-by: Olivier Grisel <[email protected]> Co-authored-by: Olivier Grisel <[email protected]> Co-authored-by: Christian Lorentzen <[email protected]>

## August 31th, 2021 ### Gael * TODO: Jeremy's renewal, Chiara's replacement, Mathis's consulting gig ### Olivier - input feature names: main PR [#18010](scikit-learn/scikit-learn#18010) that links into sub PRs - remaining (need review): [#20853](scikit-learn/scikit-learn#20853) (found a bug in `OvOClassifier.n_features_in_`) - reviewing `get_feature_names_out`: [#18444](scikit-learn/scikit-learn#18444) - next: give feedback to Chiara on ARM wheel building [#20711](scikit-learn/scikit-learn#20711) (needed for the release) - next: assist Adrin for the release process - next: investigate regression in loky that blocks the cloudpickle release [#432](cloudpipe/cloudpickle#432) - next: come back to intel to write a technical roadmap for a possible collaboration ### Julien - Was on holidays - Planned week @ Nexedi, Lille, from September 13th to 17th - Reviewed PRs - [`#20567`](scikit-learn/scikit-learn#20567) Common Private Loss module - [`#18310`](scikit-learn/scikit-learn#18310) ENH Add option to centered ICE plots (cICE) - Others PRs prior to holidays - [`#20254`](scikit-learn/scikit-learn#20254) - Adapted benchmarks on `pdist_aggregation` to test #20254 against sklearnex - Adapting PR for `fast_euclidean` and `fast_sqeuclidean` on user-facing APIs - Next: comparing against scipy's - Next: Having feedback on [#20254](scikit-learn/scikit-learn#20254) would also help - Next: I need to block time to study Cython code. ### Mathis - `sklearn_benchmarks` - Adapting benchmark script to run on Margaret - Fix issue with profiling files too big to be deployed on Github Pages - Ensure deterministic benchmark results - Working on declarative pipeline specification - Next: run long HPO benchmarks on Margaret ### Arturo - Finished MOOC! - Finished filling [Loïc's notes](https://notes.inria.fr/rgSzYtubR6uSOQIfY9Fpvw#) to find questions with score under 60% (Issue [#432](INRIA/scikit-learn-mooc#432)) - started addressing easy-to-fix questions, resulting in gitlab MRs [#21](https://gitlab.inria.fr/learninglab/mooc-scikit-learn/mooc-scikit-learn-coordination/-/merge_requests/21) and [#22](https://gitlab.inria.fr/learninglab/mooc-scikit-learn/mooc-scikit-learn-coordination/-/merge_requests/22) - currently working on expanding the notes up to 70% - Continued cross-linking forum posts with issues in GitHub, resulting in [#444](INRIA/scikit-learn-mooc#444), [#445](INRIA/scikit-learn-mooc#445), [#446](INRIA/scikit-learn-mooc#446), [#447](INRIA/scikit-learn-mooc#447) and [#448](INRIA/scikit-learn-mooc#448) ### Jérémie - back from holidays, catching up - Mathis' benchmarks - trying to find what's going on with ASV benchmarks (asv should display the versions of all build and runtime depndencies for each run) ### Guillaume - back from holidays - Next: - release with Adrin - check the PR and issue trackers ### TODO / Next - Expand Loïc’s notes up to 70% (Arturo) - Create presentation to discuss my experience doing the MOOC (Arturo) - Help with the scikit-learn release (Olivier, Guillaume) - HR: Jeremy's renewal, Chiara's replacement (Gael) - Mathis's consulting gig (Olivier, Gael, Mathis)

…t_feature_names (scikit-learn#18444) Co-authored-by: Andreas Mueller <[email protected]> Co-authored-by: Andreas Mueller <[email protected]> Co-authored-by: Olivier Grisel <[email protected]> Co-authored-by: Olivier Grisel <[email protected]> Co-authored-by: Christian Lorentzen <[email protected]>

scikit-learn/scikit-learn#18444

amueller and others added 30 commits November 20, 2018 10:52

work on get_feature_names for pipeline

ab2acbd

fix SimpleImputer get_feature_names

3bc674b

use hasattr(transform) to check whether to use final estimator in get…

1c4a78f

…_feature_names

add some docstrings

7881930

fix docstring

de63353

Merge branch 'master' into pipeline_get_feature_names

8835f3b

# Conflicts: # sklearn/base.py # sklearn/impute.py # sklearn/preprocessing/data.py

fix merge issues with master

2eba5de

fix merge issue

449ed23

Merge branch 'master' into pipeline_get_feature_names

a1fcf67

don't do magic slicing in pipeline.get_feature_names

b929341

fix merge issue

2b613e5

Merge branch 'master' of https://github.com/scikit-learn/scikit-learn …

ad66b86

…into pipeline_get_feature_names

trying to merge with input feature pr

5eb7603

Merge branch 'master' into pipeline_get_feature_names

f4f832a

remove tests taht don't apply

3a9054c

Merge branch 'pipeline_get_feature_names' of github.com:amueller/scik…

9c4420d

…it-learn into pipeline_get_feature_names

fix onetoone mixing feature names

76f5b54

remove more tests

52f38e1

fix test for better expected outputs

cdda1fb

fix priorities in catch-all get_feature_names

5f4abbc

flake8

4305a28

remove redundant code

c387b5b

fix error message

2fefb67

fix mixin order

a6832c3

small refactor with helper function

0f45b22

linting for new options

4717a73

add feature names to lineardiscriminantanalysis and birch

a658ba7

add get_feature_names in a couple more places

e9e45af

fix up docs

5acaced

make example actually work

0353f69

Update sklearn/pipeline.py

8d0b3cf

Co-authored-by: Olivier Grisel <[email protected]>

lorentzenchr approved these changes Sep 6, 2021

View reviewed changes

Comment thread doc/glossary.rst Outdated

Comment thread doc/glossary.rst Outdated

lorentzenchr added 2 commits September 6, 2021 19:06

Update doc/glossary.rst

c35f7aa

Update doc/glossary.rst

ec8b825

lorentzenchr added this to the 1.0 milestone Sep 6, 2021

ENH Adds one-to-one transformers

560c0d0

Add one more test for one-to-one feature transformers with pandas

043540b

ogrisel merged commit 4abd9f2 into scikit-learn:main Sep 7, 2021

ogrisel added the To backport PR merged in master that need a backport to a release branch defined based on the milestone. label Sep 7, 2021

shubhraneel mentioned this pull request Sep 8, 2021

ENH add support for 'passthrough' in FeatureUnion #20860

Merged

This was referenced Sep 17, 2021

ENH Adds feature_names_out to impute module #21078

Merged

ENH Adds feature_names_out to preprocessing module #21079

Merged

ogrisel mentioned this pull request Oct 13, 2021

Implement get_feature_names_out for all estimators #21308

Closed

14 tasks

falcaopetri mentioned this pull request Oct 17, 2021

Use new transformer.get_feature_names_out function scikit-learn-contrib/sklearn-pandas#248

Open

ogrisel mentioned this pull request Nov 17, 2021

ENH Add get_feature_names_out to FunctionTransformer #21569

Merged

eddiebergman mentioned this pull request Nov 15, 2022

Update scikit learn 1.2 automl/auto-sklearn#1611

Closed

54 tasks

SeppeDeWinter mentioned this pull request Dec 19, 2022

AttributeError when call run_scenicplus aertslab/scenicplus#76

Closed

smlindauer mentioned this pull request Apr 22, 2024

Open Source Code Node Example - Deprecated scikit-learn functionality sassoftware/sas-viya-dmml-pipelines#12

Closed

gregcaporaso added a commit to qiime2/q2-sample-classifier that referenced this pull request Apr 30, 2024

address get_feature_names to get_feature_names_out API change

1f561d3

scikit-learn/scikit-learn#18444

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

API Implements get_feature_names_out for transformers that support get_feature_names#18444

API Implements get_feature_names_out for transformers that support get_feature_names#18444
ogrisel merged 121 commits intoscikit-learn:mainfrom
thomasjpfan:get_output_names

thomasjpfan commented Sep 23, 2020 •

edited by ogrisel

Loading

Uh oh!

lorentzenchr left a comment

Uh oh!

Uh oh!

Uh oh!

thomasjpfan commented Sep 6, 2021 •

edited

Loading

Uh oh!

lorentzenchr commented Sep 6, 2021

Uh oh!

ogrisel commented Sep 6, 2021

Uh oh!

lorentzenchr commented Sep 6, 2021

Uh oh!

adrinjalali commented Sep 6, 2021

Uh oh!

thomasjpfan commented Sep 6, 2021

Uh oh!

ogrisel commented Sep 7, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

thomasjpfan commented Sep 23, 2020 • edited by ogrisel Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Uh oh!

lorentzenchr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

thomasjpfan commented Sep 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lorentzenchr commented Sep 6, 2021

Uh oh!

ogrisel commented Sep 6, 2021

Uh oh!

lorentzenchr commented Sep 6, 2021

Uh oh!

adrinjalali commented Sep 6, 2021

Uh oh!

thomasjpfan commented Sep 6, 2021

Uh oh!

ogrisel commented Sep 7, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

thomasjpfan commented Sep 23, 2020 •

edited by ogrisel

Loading

thomasjpfan commented Sep 6, 2021 •

edited

Loading