Skip to content

MNT Refactor scorer using _get_response #18212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
glemaitre wants to merge 19 commits into from
Closed

MNT Refactor scorer using _get_response #18212

glemaitre wants to merge 19 commits into from

Conversation

@glemaitre
Copy link
Member

@glemaitre glemaitre commented Aug 20, 2020

Continuation of #18114 where we can factorize some code.

@glemaitre glemaitre changed the title Refactor get response MNT Refactor scorer using _get_response Aug 20, 2020
@glemaitre
Copy link
Member Author

glemaitre commented Aug 20, 2020

I would prefer to merge #18114 first to solve the bug.

This refactoring can also be beneficial for #16525.

@glemaitre glemaitre mentioned this pull request Aug 21, 2020
Merged
@glemaitre glemaitre closed this Oct 9, 2020
@glemaitre glemaitre mentioned this pull request Oct 9, 2020
Closed
@glemaitre glemaitre mentioned this pull request Sep 9, 2021
Closed
@glemaitre glemaitre mentioned this pull request Nov 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

module:metrics

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@glemaitre