Skip to content

Conversation

@ogrisel
Copy link
Member

@ogrisel ogrisel commented Dec 17, 2019

PR to debug CI failure reported as #15908.

@ogrisel
Copy link
Member Author

ogrisel commented Dec 18, 2019

Ok so the problem is that coverage calls os.path.relpath(filename) with filename=D:\\a\\tmp_folder\\.coverage.fv-az639.3520.998466 while the current working directory (at least in the subprocess) is in the site-packages folder on the c:\\ drive:

cwd        = 'c:\\miniconda\\envs\\testvenv\\lib\\site-packages'

Hence the ValueError raised by relpath.

The fact that the cwd is in site-package is probably a side effect of pytest --pyargs, e.g. to have the conftests.py.

I will open a PR to make coverage robust to this case. But this is weird that it does not crash in general (that is for the coverage file that are generated from the main process).

@ogrisel
Copy link
Member Author

ogrisel commented Dec 18, 2019

Upstream fix seems to work as expected. Closing debug PR.

@ogrisel ogrisel closed this Dec 18, 2019
@ogrisel ogrisel deleted the ci-windows-relpath branch December 18, 2019 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant