Skip to content

Conversation

@jigna-panchal
Copy link
Contributor

Reference Issues/PRs

Issue #14312 - updated documentation for naive_bayes.py

What does this implement/fix? Explain your changes.

Added classes_ attribute to CategoricalNB
Alphabetized the attributes in all of the classes (i.e. ComplementNB, BenoulliNB, etc)
Deleted multiple instances of attribut classes_ for BernoulliNB, MultinomialNB, and GaussianNB
Deleted extra whitespace
Removed scipy.sparse.issparse as it is not used

Any other comments?

@eickenberg
Copy link
Contributor

Looks good to me pending CI

@amueller
Copy link
Member

amueller commented Nov 3, 2019

linting is failing

@jigna-panchal
Copy link
Contributor Author

All checks passes now, should be good to go after latest commit.

@cmarmo
Copy link
Contributor

cmarmo commented Dec 13, 2019

@jigna-panchal, I think this PR went out of the radar during the 0.22 release process.
Do you think you could find some time to synchronize with master? As you said, is almost done. Thanks for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants