[MRG] BUG Fixes duck typing in voting #14287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnothman
reviewed
Jul 7, 2019
| ('lr', clf1), ('rf', clf2), ('gnb', clf3)], | ||
| voting='hard') | ||
| eclf.fit(X, y) | ||
| assert not hasattr(eclf, "predict_proba") |
Member
There was a problem hiding this comment.
This would apply even before fit
jnothman
approved these changes
Jul 7, 2019
| with pytest.raises(AttributeError, match=msg): | ||
| eclf.predict_proba | ||
|
|
||
| with pytest.raises(AttributeError, match=msg): |
Member
There was a problem hiding this comment.
This is redundant wrt the previous assertion
rth
approved these changes
Jul 8, 2019
Member
rth
left a comment
rth
left a comment
There was a problem hiding this comment.
Thanks! I imagine we don't need a what's new entry for this?
Member
|
A what's new entry doesn't hurt, and helps us to find things when problems
arise. "The predict_proba attribute will no longer be present when
voting='hard'."
|
qinhanmin2014
approved these changes
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the ducktyping of
predict_probainVotingClassifier.