CI skip HashVectorizer test on pypy #13729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@rth could you have a look |
rth
approved these changes
Apr 26, 2019
Member
rth
left a comment
rth
left a comment
There was a problem hiding this comment.
Ahh, yes, makes sense for these newly added tests. Thanks.
rth
changed the title
Member
Author
|
But it seems linked with the gradient boosting "Too long with no output (exceeded 10m0s)" |
Member
|
Hmm... yes, could it be too much to be fitting the whole of Boston in a doctest?? |
Member
|
Nah. That shouldn't be the problem...? I had forgotten Boston was so small. |
Member
|
I wonder if PyPy doesn't like our experimental import mechanism. |
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 740c61b.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 740c61b.
marcelobeckmann
pushed a commit
to marcelobeckmann/scikit-learn
that referenced
this pull request
May 1, 2019
marcelobeckmann
pushed a commit
to marcelobeckmann/scikit-learn
that referenced
this pull request
May 1, 2019
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve the failure in CircleCI related with pypy