MAINT/DOC update CI and add note to doc regarding matplotlib #13720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doc/install.rst
Outdated
| - NumPy (>= 1.11.0), | ||
| - SciPy (>= 0.17.0). | ||
|
|
||
| Scikit-learn plotting capabilities require Matplotlib (>= 1.5.1). Some of the |
Member
There was a problem hiding this comment.
(i.e., functions start with "plot_")
Member
|
I guess we need to leave #13335 open since we still need to clean the code in plot_tree. |
rth
approved these changes
Apr 25, 2019
doc/install.rst
Outdated
|
|
||
| Scikit-learn plotting capabilities require Matplotlib (>= 1.5.1). Some of the | ||
| scikit-learn examples might require one or more extra dependencies: | ||
| scikit-image (>= 0.12.3), pandas (>= 0.18.0), and joblib (>= 0.11) |
Member
There was a problem hiding this comment.
joblib is not an extra dependency -- you won't be able to import sklearn without it ;)
qinhanmin2014
approved these changes
Apr 26, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…cikit-learn#13720)" This reverts commit 721f007.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…cikit-learn#13720)" This reverts commit 721f007.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially address #13335
I added matplotlib to the
ubuntubuild and update the documentation.