Skip to content

Conversation

@thomasjpfan
Copy link
Member

This PR attempts to fix a latex issue when building the docs on circleci.

@thomasjpfan thomasjpfan changed the title [WIP] Fixes latex pdf issue [MRG] Fixes latex pdf issue Apr 25, 2019
@adrinjalali
Copy link
Member

Could you maybe trigger the full pdf build here and see if it works?

@thomasjpfan
Copy link
Member Author

Looks like I need to modify build_doc.sh trigger (and than revert it when/if it works)

@glemaitre glemaitre self-requested a review April 25, 2019 19:08
@thomasjpfan
Copy link
Member Author

Looks like it works, removing the code that forces the pdf to build.

@glemaitre
Copy link
Member

Since this doc, I am merging then.
@thomasjpfan thanks to a give a look at it

@glemaitre glemaitre merged commit 37a9d18 into scikit-learn:master Apr 25, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants