[MRG] Remove np.seterr calls in test files #13712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditya1702
changed the title
Contributor
Author
|
@NicolasHug @jnothman The tests are passing with np.seterr removed. We can remove the statements |
NicolasHug
reviewed
Apr 25, 2019
|
|
||
|
|
||
| np.seterr(all='warn') | ||
| # np.seterr(all='warn') |
Member
There was a problem hiding this comment.
please remove them entirely then, not just uncomment ;)
Contributor
Author
There was a problem hiding this comment.
@NicolasHug Commented them to just test the changes. Removed them now
aditya1702
changed the title
Contributor
Author
|
@NicolasHug Can be merged |
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 12e3cd5.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 12e3cd5.
marcelobeckmann
pushed a commit
to marcelobeckmann/scikit-learn
that referenced
this pull request
May 1, 2019
marcelobeckmann
pushed a commit
to marcelobeckmann/scikit-learn
that referenced
this pull request
May 1, 2019
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #13650
What does this implement/fix? Explain your changes.
Removes np.seterr calls