DOC use :pr: rather than :issue: in what's new #13701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of these may actually be Issues, but better to set a convention
Member
Author
|
The x is due to long lines in the sphinx_issues extension. Ignore it. |
thomasjpfan
approved these changes
Apr 24, 2019
doc/conf.py
Outdated
| issues_uri = 'https://github.com/scikit-learn/scikit-learn/issues/{issue}' | ||
| # we use the issues path for PRs since the issues URL will forward | ||
| issues_github_path = 'scikit-learn/scikit-learn' | ||
| issues_user_uri = 'https://github.com/{user}' |
Member
There was a problem hiding this comment.
issues_user_uri can be removed as well
thomasjpfan
approved these changes
Apr 24, 2019
glemaitre
approved these changes
Apr 25, 2019
Member
glemaitre
left a comment
glemaitre
left a comment
There was a problem hiding this comment.
LGTM. I will just make sure that we don't have mistake will the last PR in master and address the comment of Thomas
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Apr 25, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of these may actually be Issues, but better to set a convention