[MRG] Fix OpenMP runtime error on mac #13294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
approved these changes
Feb 27, 2019
Member
ogrisel
left a comment
ogrisel
left a comment
There was a problem hiding this comment.
Looks good to me. Maybe we can just extend the comment to make it even more explicit that we handle oversubscription by manually reconfiguring the inner OpenMP loops.
Member
|
Any idea why circleci is killed like that? |
Member
Author
|
No idea but we've already seen this failure last week, right ? |
Member
|
Related to OpenML/ARFF reader taking too much memory: #13287 |
glemaitre
reviewed
Feb 27, 2019
glemaitre
approved these changes
Feb 27, 2019
Member
glemaitre
left a comment
glemaitre
left a comment
There was a problem hiding this comment.
LGTM. Just a nitpick. @jeremiedbb I will merge once you corrected it.
jeremiedbb
force-pushed
the
fix-macos-openmp-runtimes
branch
from
482f8e9 to
33c46df
Compare
Member
Author
|
@glemaitre the travis failure seems unrelated. It's a http error. |
Member
|
Thanks |
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 59f5b41.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 59f5b41.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids runtime error from OpenMP due to multiple OpenMP runtime libs loaded simultaneously.
Happens when calling BLAS inside prange parallel loop.
Happens only on mac...
ping @ogrisel