[MRG+2] Fix warning in MultinomialNB.partial_fit when target class was not yet observed #13280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agramfort
changed the title
agramfort
approved these changes
Feb 26, 2019
Member
|
LGTM. +1 for merge when CI has run. |
GaelVaroquaux
approved these changes
Feb 26, 2019
GaelVaroquaux
changed the title
Member
|
this PR also solves similar issues in ComplementNB and BernoulliNB, right? |
qinhanmin2014
approved these changes
Feb 26, 2019
Contributor
Author
|
@qinhanmin2014 yes, you are right. The check is implemented in base class, so it should work also for the other NB models. |
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…s not yet observed (scikit-learn#13280)
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…class was not yet observed (scikit-learn#13280)" This reverts commit 7450b55.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…class was not yet observed (scikit-learn#13280)" This reverts commit 7450b55.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
…s not yet observed (scikit-learn#13280)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #13232
What does this implement/fix? Explain your changes.
It silences the runtime warning in
partial_fitwhen a target class was not observed, which results in log of 0s. This should not affect the predictions as demonstrated in the implemented unit test. It does have an unpleasant effect of producing -inf inclass_log_prior_attribute when the class was not yet observed. This value is then updated after adding a training case with such a class.Any other comments?
Ping: @GaelVaroquaux