DOC: Inclusion criteria for speed ups #13255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Document better the inclusion criteria for new algorithm to speed up an existing problem.
vene
reviewed
Feb 25, 2019
doc/faq.rst
Outdated
| - It does not introduce new hyper-parameters (as it makes the library | ||
| more future-proof) | ||
| - It is easy to document clearly when the contribution improves the speed | ||
| and when it does not. |
Member
There was a problem hiding this comment.
this second point might benefit from an example "(e.g. when n_features >> n_samples)"
might want periods at the end of every list item for consistency
vene
reviewed
Feb 25, 2019
doc/faq.rst
Outdated
| more future-proof), | ||
| - it is easy to document clearly when the contribution improves the speed | ||
| and when it does not, for instance "when n_features >> | ||
| n_samples)", |
Member
There was a problem hiding this comment.
thanks! seems like there's a spurious parenthesis, otherwise lgtm
agramfort
approved these changes
Feb 25, 2019
qinhanmin2014
approved these changes
Feb 25, 2019
albertcthomas
approved these changes
Feb 25, 2019
jnothman
approved these changes
Feb 25, 2019
Member
|
Let's merge |
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
)" This reverts commit cf79cc1.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
)" This reverts commit cf79cc1.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document better the inclusion criteria for new algorithm to speed up an existing problem.
Summarizes discussion at the sprint with @jnothman @adrinjalali @ogrisel and others.