[MRG+2] DOC data centering in PCA #13242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ile for sklearn.decomposition.pca, author:Ismael Lemhadri, date:16 Oct 2017], modified the help file of "sklearn/decomposition/pca.py" to make it clear that the data matrix is centered (but not scaled) before performing singular value decomposition.
The documentation now explicits that PCA scales the input but it does not scale it.
GaelVaroquaux
changed the title
agramfort
reviewed
Feb 25, 2019
agramfort
reviewed
Feb 25, 2019
Fix grammar.
agramfort
changed the title
Member
|
thx @AssiaBen |
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
[MRG+2] DOC data centering in PCA
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 6223b30.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 6223b30.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
[MRG+2] DOC data centering in PCA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues #9934.
The previous PR #9934 improves the PCA documentation by expliciting that PCA centers the data before SVD. This additional information was not added to IPCA. This new PR does.