[MRG] MNT Ignore mypy cache folder #12963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
One of the travis build aborted for unknown reason https://travis-ci.org/scikit-learn/scikit-learn/jobs/478664426#L2137 |
nixphix
force-pushed
the
fix/gitignore-mypy
branch
from
992b0e3 to
3c80203
Compare
Member
|
Thanks @nixphix ! TBH, there are probably like 2 people running mypy on the scikit-learn code base, so I'm not convinced it's an issue that needs fixing. Let's wait for a second option. |
Contributor
Author
|
No rush, I just thought we would need it eventually |
Member
|
I don't think this hurts, as it's becoming a more standard part of tooling |
Member
|
I think it is too trivial to deserve further discussion |
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit ff63520.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit ff63520.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #12962
What does this implement/fix? Explain your changes.
Adds mypy cache folder to
.gitignorefile