[MRG] Fix builtin PrettyPrinter usage on estimators #12938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
changed the title
adrinjalali
approved these changes
Jan 12, 2019
Member
adrinjalali
left a comment
adrinjalali
left a comment
There was a problem hiding this comment.
LGTM, thanks @NicolasHug !
jnothman
approved these changes
Jan 14, 2019
Member
|
It is possible that we should still enhance this, making sure that estimators are pretty-printed by pprint also. |
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #12906
What does this implement/fix? Explain your changes.
This PR makes a copy of the
_dispatchdict in_EstimatorPrettyPrinterto prevent the builtinPrettyPrinterclass to directly call_EstimatorPrettyPrinter._print_estimatoron estimator objects, which fails since_print_estimatorassumes the object is an instance of_EstimatorPrettyPrinterwith specific attributes.Any other comments?
Note that even when only
PrettyPrinteris used, estimators will still be rendered with_EstimatorPrettyPrintersincePrettyPrinterinternally usesrepr()which itself uses_EstimatorPrettyPrinter.So using
PrettyPrinteror_EstimatorPrettyPrinteron an estimator has the exact same effect.