Skip to content

[MRG] circle-ci should only run/build plot_* files #12797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qinhanmin2014 merged 10 commits into from
Dec 28, 2018
+1 −2
Merged

[MRG] circle-ci should only run/build plot_* files #12797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
419912d
touch an example with tk requirement
adrinjalali Dec 16, 2018
e92a300
add tcl and tk to circle-ci
adrinjalali Dec 16, 2018
2ffd588
revert tcl tk installation
adrinjalali Dec 18, 2018
eec5a8f
limit to doc build to plot_* files
adrinjalali Dec 18, 2018
c970755
remove the import __future__ line
adrinjalali Dec 18, 2018
e4ade5f
also apply the filter when detecting changed files
adrinjalali Dec 22, 2018
4bf448d
revert changed files filter
adrinjalali Dec 27, 2018
ff6f363
include all rst files as well
adrinjalali Dec 27, 2018
bd5b4de
move the filter to change_examples
adrinjalali Dec 28, 2018
69f9109
fix the grep line
adrinjalali Dec 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build_tools/circle/build_doc.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ get_build_type() {
echo QUICK BUILD: no changed filenames for $git_range
return
fi
changed_examples=$(echo "$filenames" | grep -e ^examples/)
changed_examples=$(echo "$filenames" | grep -E "^examples/(.*/)*plot_")
Copy link
Copy Markdown
Member

@qinhanmin2014 qinhanmin2014 Dec 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grep -e seems enough?

Copy link
Copy Markdown
Member

@qinhanmin2014 qinhanmin2014 Dec 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adrinjalali Hmm, I tried locally and seems that grep -E won't work, I'm not familiar with -E.

Copy link
Copy Markdown
Member Author

@adrinjalali adrinjalali Dec 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the -E just gives special meaning to ( and ), works for me. For me it's equivalent to grep -e "^examples/\(.*/\)*plot_"

Copy link
Copy Markdown
Member

@qinhanmin2014 qinhanmin2014 Dec 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies I went through your code too quickly.

if [[ -n "$changed_examples" ]]
then
echo BUILD: detected examples/ filename modified in $git_range: $changed_examples
Expand Down
1 change: 0 additions & 1 deletion examples/applications/svm_gui.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
If all examples are from the same class, it uses a one-class SVM.

"""
from __future__ import division, print_function

print(__doc__)

Expand Down