Skip to content

Conversation

@jeremiedbb
Copy link
Member

Fixes #12440

Comes from a bad copy paste...

it would be nice to have a backport in 0.20.1, since it was introduce in 0.20, to not provide wrong informations for too long.

Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rth rth added this to the 0.20.1 milestone Oct 23, 2018
Copy link
Member

@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please add a what's new entry

@qinhanmin2014 qinhanmin2014 changed the title [MRG] FIX olivetti_faces DESCR to point to the good location [MRG+2] FIX olivetti_faces DESCR to point to the good location Oct 23, 2018
@qinhanmin2014 qinhanmin2014 merged commit 013d295 into scikit-learn:master Oct 23, 2018
@jeremiedbb jeremiedbb deleted the fix-olivetti-DESCR branch October 24, 2018 11:53
thoo pushed a commit to thoo/scikit-learn that referenced this pull request Nov 14, 2018
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request Nov 14, 2018
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request Nov 14, 2018
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants