Fix the link to computing docs on README #12380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinhanmin2014
approved these changes
Oct 15, 2018
Member
qinhanmin2014
left a comment
qinhanmin2014
left a comment
There was a problem hiding this comment.
LGTM, thanks @gustavodemari
Appveyor failure unrelated.
anuragkapale
pushed a commit
to anuragkapale/scikit-learn
that referenced
this pull request
Oct 23, 2018
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Nov 14, 2018
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 9e7ed1f.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 9e7ed1f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
On the release of scikit 0.20, the computing docs file have changed from "computational_performance.rst" to "computing.rst"
https://github.com/scikit-learn/scikit-learn/blob/0.20.X/doc/modules/computing.rst
https://github.com/scikit-learn/scikit-learn/blob/0.19.X/doc/modules/computational_performance.rst
In consequence, the link from README.rst pointing to the Linear Algebra section in the Computing page wasn't working because it was pointing to the old link.
So, this PR fixes the broken link of the computing section on the README.rst.