BUG: fix OrdinalEncoder with manually specified categories #12367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
reviewed
Oct 12, 2018
| def test_ordinal_encoder_specified_categories(X, X2, cats, cat_dtype): | ||
| enc = OrdinalEncoder(categories=cats) | ||
| exp = np.array([[0.], [1.]]) | ||
| assert_array_equal(enc.fit_transform(X), exp) |
Member
There was a problem hiding this comment.
Would it be better to use assert_allclose?
Member
Author
There was a problem hiding this comment.
within the file, mainly assert_array_equal is used, so I would stick with that for consistency.
Since it is here always about encoded integers, it should also not matter much in this case
rth
approved these changes
Oct 13, 2018
Member
rth
left a comment
rth
left a comment
There was a problem hiding this comment.
LTGM, thanks @jorisvandenbossche !
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Oct 15, 2018
anuragkapale
pushed a commit
to anuragkapale/scikit-learn
that referenced
this pull request
Oct 23, 2018
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…ikit-learn#12367)" This reverts commit a48484d.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…ikit-learn#12367)" This reverts commit a48484d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12365