[MRG] Minor doc update in ensemble.rst #11810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor doc improvement
amueller
reviewed
Oct 16, 2018
doc/modules/ensemble.rst
Outdated
| F_m(x) = F_{m-1}(x) + \arg\min_{h} \sum_{i=1}^{n} L(y_i, | ||
| F_{m-1}(x_i) + h(x)) | ||
| F_{m-1}(x_i) + h(x_i)) |
Member
There was a problem hiding this comment.
I find this still pretty unclear tbh. the argmin returns a tree h, but on the left-hand side we apply F_m to x. So the operation of "apply the argmin to x" is missing.
So I'd break it up in to F_m(x) = F_{m-1}(x) + \gamma_m h_m(x) (which is above)
and say h_m is given as h_m = argmin ....
amueller
approved these changes
Oct 16, 2018
Member
amueller
left a comment
amueller
left a comment
There was a problem hiding this comment.
I think this is much clearer, thanks!
jnothman
approved these changes
Oct 17, 2018
Member
|
Thanks @NicolasHug |
anuragkapale
pushed a commit
to anuragkapale/scikit-learn
that referenced
this pull request
Oct 23, 2018
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Nov 14, 2018
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Nov 14, 2018
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 82428c5.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 82428c5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Minor doc improvement
Any other comments?