-
-
Notifications
You must be signed in to change notification settings - Fork 26.5k
[MRG] [RFC] multiclass and types_of_target #11213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1a73583 to
cb57d0a
Compare
|
Do you think that this is understandable? |
cb57d0a to
b2d9563
Compare
|
It looks reasonable, but a lot of the information is redundant with the glossary section on target types. So perhaps it makes more sense to refer the reader there for details on formats and APIs. |
|
To refer to the glossary, you should use the |
efb307b to
15da70a
Compare
|
in a conversation at scipy2018, @ivanov suggested that maybe the problem for rewording the multiclass was that the examples were not the 'same' for all the scenarios. So here's a draft. I'm not really sure that all the examples make sense or are clear enough. So, comments are welcome!! If anyone can think of a different set of coherent examples, don't be shy. here's the artifact https://27909-843222-gh.circle-artifacts.com/0/doc/modules/multiclass.html |
|
IMO, I find that the changes make the documentation hard to read (too much level of bullet points) |
15da70a to
b17598a
Compare
|
@lucyleeow can you give it a read? and we finish it |
| for each data-point, such as wind direction and magnitude at a | ||
| certain location. | ||
| - valid :term:`multiclass` representation for | ||
| :func:`~utils.multiclass.type_of_target` (`y`) are: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@massich it's still failing - but this may be because master is broken? |
|
Yes, CI still fails on master cf #14956 (comment) . We need to investigate it. |
|
Closing in favor of #15333 since @lucyleeow did a great job! |
Reference Issues/PRs
fixes #9777
What does this implement/fix? Explain your changes.
Any other comments?
This PR should be entered before #9059