Skip to content

Conversation

@massich
Copy link
Contributor

@massich massich commented Jun 6, 2018

Reference Issues/PRs

fixes #9777

What does this implement/fix? Explain your changes.

Any other comments?

This PR should be entered before #9059

@massich massich changed the title [WIP] [WIP] multiclass and types_of_target Jun 6, 2018
@massich massich force-pushed the multiclass_type_of_target branch from 1a73583 to cb57d0a Compare July 10, 2018 03:28
@massich
Copy link
Contributor Author

massich commented Jul 10, 2018

@massich massich force-pushed the multiclass_type_of_target branch from cb57d0a to b2d9563 Compare July 10, 2018 22:42
@jnothman
Copy link
Member

It looks reasonable, but a lot of the information is redundant with the glossary section on target types. So perhaps it makes more sense to refer the reader there for details on formats and APIs.

@jnothman
Copy link
Member

To refer to the glossary, you should use the term role, e.g. :term:`multiclass`

@massich massich force-pushed the multiclass_type_of_target branch from efb307b to 15da70a Compare July 16, 2018 03:24
@massich massich changed the title [WIP] multiclass and types_of_target [MRG] multiclass and types_of_target Jul 16, 2018
@massich massich changed the title [MRG] multiclass and types_of_target [RFC] multiclass and types_of_target Jul 16, 2018
@massich
Copy link
Contributor Author

massich commented Jul 16, 2018

in a conversation at scipy2018, @ivanov suggested that maybe the problem for rewording the multiclass was that the examples were not the 'same' for all the scenarios.

So here's a draft. I'm not really sure that all the examples make sense or are clear enough. So, comments are welcome!!

If anyone can think of a different set of coherent examples, don't be shy.

here's the artifact https://27909-843222-gh.circle-artifacts.com/0/doc/modules/multiclass.html

@massich massich changed the title [RFC] multiclass and types_of_target [MRG] [RFC] multiclass and types_of_target Jul 16, 2018
@glemaitre
Copy link
Member

IMO, I find that the changes make the documentation hard to read (too much level of bullet points)

@massich
Copy link
Contributor Author

massich commented Sep 6, 2019

@lucyleeow can you give it a read? and we finish it

@massich
Copy link
Contributor Author

massich commented Sep 6, 2019

@massich
Copy link
Contributor Author

massich commented Sep 6, 2019

for each data-point, such as wind direction and magnitude at a
certain location.
- valid :term:`multiclass` representation for
:func:`~utils.multiclass.type_of_target` (`y`) are:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucyleeow
Copy link
Member

lucyleeow commented Sep 11, 2019

@massich it's still failing - but this may be because master is broken?

@rth
Copy link
Member

rth commented Sep 11, 2019

Yes, CI still fails on master cf #14956 (comment) . We need to investigate it.

@massich
Copy link
Contributor Author

massich commented Oct 22, 2019

Closing in favor of #15333 since @lucyleeow did a great job!

@massich massich closed this Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

calling type_of_target crashes before returning unknown

6 participants