-
-
Notifications
You must be signed in to change notification settings - Fork 26.5k
Closed
Labels
EasyWell-defined and straightforward way to resolveWell-defined and straightforward way to resolveEnhancementModerateAnything that requires some knowledge of conventions and best practicesAnything that requires some knowledge of conventions and best practicesPerformancemodule:decomposition
Description
Describe your proposed solution
The function _ica_par has the following line of code:
| lim = max(abs(abs(np.diag(np.dot(W1, W.T))) - 1)) |
We could investigate, if performance is improved by replacing np.diag(np.dot(W1, W.T)) by np.einsum("ij,ij->i", W1, W).
Additional context
A short benchmark would be nice in order to decide whether it's worth.
Metadata
Metadata
Assignees
Labels
EasyWell-defined and straightforward way to resolveWell-defined and straightforward way to resolveEnhancementModerateAnything that requires some knowledge of conventions and best practicesAnything that requires some knowledge of conventions and best practicesPerformancemodule:decomposition