-
-
Notifications
You must be signed in to change notification settings - Fork 26.5k
Closed
Labels
Description
In the script that build the documentation: build_tools/circle/build_doc.sh, we have the following line:
scikit-learn/build_tools/circle/build_doc.sh
Lines 179 to 182 in 86bda0a
| source activate testenv | |
| pip install sphinx-gallery | |
| pip install numpydoc | |
| pip install sphinx-prompt |
Indeed, the build doc-min-dependencies check that we build the documentation with a minimum version. However, these lines bypass this purpose. However the file sklearn/_min_dependencies.py are defining minimum version for these packages:
scikit-learn/sklearn/_min_dependencies.py
Lines 40 to 43 in 86bda0a
| 'sphinx-gallery': ('0.7.0', 'docs'), | |
| 'numpydoc': ('1.0.0', 'docs'), | |
| 'Pillow': ('7.1.2', 'docs'), | |
| 'sphinx-prompt': ('1.3.0', 'docs'), |
I think that we should as well take into consideration the minimum version when installing these packages.