Skip to content

Tree MAE is not considering sample_weights when calculating impurity! #11460

@JohnStott

Description

@JohnStott

This is clearly visible by looking at the code in _criterion.pyx -> class MAE -> children_impurity and node_impurity.

I will shortly provide a pull request link with a fix for the above... I have created this issue so that impacts of negative sample weights can be discussed (if necessary)?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions