remove in-function parameter validation for datasets.make_moons

Théophile Baranger · Théophile Baranger · commit 6c9f77848d9b · 2023-03-24T23:11:05.000+01:00
diff --git a/sklearn/datasets/_samples_generator.py b/sklearn/datasets/_samples_generator.py
@@ -819,12 +819,7 @@ def make_moons(n_samples=100, *, shuffle=True, noise=None, random_state=None):
         n_samples_out = n_samples // 2
         n_samples_in = n_samples - n_samples_out
     else:
-        try:
-            n_samples_out, n_samples_in = n_samples
-        except ValueError as e:
-            raise ValueError(
-                "`n_samples` can be either an int or a two-element tuple."
-            ) from e
+        n_samples_out, n_samples_in = n_samples
 
     generator = check_random_state(random_state)
 
diff --git a/sklearn/datasets/tests/test_samples_generator.py b/sklearn/datasets/tests/test_samples_generator.py
@@ -636,18 +636,6 @@ def test_make_moons_unbalanced():
     assert X.shape == (12, 2), "X shape mismatch"
     assert y.shape == (12,), "y shape mismatch"
 
-    with pytest.raises(
-        ValueError,
-        match=r"`n_samples` can be either an int " r"or a two-element tuple.",
-    ):
-        make_moons(n_samples=[1, 2, 3])
-
-    with pytest.raises(
-        ValueError,
-        match=r"`n_samples` can be either an int " r"or a two-element tuple.",
-    ):
-        make_moons(n_samples=(10,))
-
 
 def test_make_circles():
     factor = 0.3
