Skip to content

VOTE SLEP 20: Simplifying Governance Changes #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thomasjpfan merged 2 commits into from
Feb 22, 2023
Merged

VOTE SLEP 20: Simplifying Governance Changes #85

thomasjpfan merged 2 commits into from
Feb 22, 2023

Conversation

@thomasjpfan
Copy link
Member

@thomasjpfan thomasjpfan commented Jan 20, 2023

SLEP020: Simplifying Governance Changes proposes to permit governance changes through GitHub Pull Requests, where a vote will also occur in the Pull Request.

According to our governance model, the vote will be open for a month (till February 20), and the motion is accepted if 2/3 of the cast votes are in favor.

@scikit-learn/core-devs

lorentzenchr
lorentzenchr approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

GaelVaroquaux
GaelVaroquaux approved these changes Jan 21, 2023
View reviewed changes
Copy link
Member

@GaelVaroquaux GaelVaroquaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@thomasjpfan
Copy link
Member Author

thomasjpfan commented Feb 22, 2023

I am merging because the voting period has ended and the proposal has been accepted!

@thomasjpfan thomasjpfan merged commit 24db8ea into scikit-learn:main Feb 22, 2023
@thomasjpfan thomasjpfan deleted the accept_slep_020 branch February 22, 2023 15:10
@thomasjpfan thomasjpfan mentioned this pull request Feb 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnothman jnothman jnothman approved these changes

@ogrisel ogrisel ogrisel approved these changes

@GaelVaroquaux GaelVaroquaux GaelVaroquaux approved these changes

@adrinjalali adrinjalali adrinjalali approved these changes

@lesteve lesteve lesteve approved these changes

@glemaitre glemaitre glemaitre approved these changes

@jjerphan jjerphan jjerphan approved these changes

@lorentzenchr lorentzenchr lorentzenchr approved these changes

@Micky774 Micky774 Micky774 approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

+2 more reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

@TomDLT TomDLT TomDLT approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.