Temporary fix for Visual Studio & Clang incompatibility in Windows image#7835
Conversation
lagru
added
🤖 type: Infrastructure
lagru
left a comment
lagru
left a comment
There was a problem hiding this comment.
Thanks @matthew-brett for finding that issue and fix. So, this is a temporary workaround and the correct fix depends on upstream (GitHub) fixing an incompatibility between visual studio and clang. They upgraded the first but forgot to update the latter?
Can we avoid noise like this in the future? E.g. by pinning to something different from windows-latest? I remember that image updates by GitHub have caused similar issues in the past.
lagru
changed the title
|
This should also affect the windows job in our |
|
Perhaps trying if we can upgrade to |
matthew-brett
force-pushed
the
fix-windows-clang-ci
branch
from
a69d995 to
3ab47c3
Compare
* origin/main: Deprecate estimate method in favor of class constructor (scikit-image#7771) Temporary fix for Visual Studio & Clang incompatibility in Windows image (scikit-image#7835) Address deprecations in Pillow 11.3 (scikit-image#7828) Remove unused & obsolete `legacy_datasets`, `legacy_registry` vars (scikit-image#7677) Draft migration guide for skimage2 (scikit-image#7785) Do not report failure in wheels sub-recipe (scikit-image#7806) Use consistent wording in property description. (scikit-image#7804) Add intensity_median to regionprops (scikit-image#7745) CI: Update pypa/gh-action-pypi-publish to v1.12.4 for attestations on PyPI (scikit-image#7793) Document output dtype for transform.resize. (scikit-image#7792) Use `cibuildwheel` to build WASM/Pyodide wheels for `scikit-image`, push nightlies to Anaconda.org (scikit-image#7440) DOC: Include missing gain parameter in adjust_gamma equation (scikit-image#7763) Temporarily pin to `pyodide-build==0.30.0`, and ensure that the correct xbuildenvs are used (scikit-image#7788) Deprecate old names & attributes in RegionProperties (scikit-image#7778) Pin JasonEtco/create-an-issue action to SHA for v2.9.2 (scikit-image#7787) Make doctest-plus work with spin (scikit-image#7786) Report failures on main via issue (scikit-image#7752) Use `workers` instead of alternate parameter names (scikit-image#7302) Fix f-string in otsu plot (scikit-image#7780) Further document use of regionprops function and fix terms. (scikit-image#7518)
|
Just as a comment, this should be irrelevant, but is caused by STL picking up the clang in the image (even if you don't use it), and GHA publishing inconsistent images. Other workarounds are to use the windows-2025 image, or set the undocumented |
|
Thanks. I'm already tried the windows-2025 image in #7836. Building seems to work fine and it only breaks one test, so promising. Curious if you know of any other points in favor of or against updating to the 2025 image. |
|
The choice of image on windows generally has no discernible impact in my experience. This case here is a rare exception. |
* origin/main: (31 commits) Update import convention in certain gallery examples (scikit-image#7764) Refactor fundamental matrix scaling (scikit-image#7767) Add unit test for cval unequal to zero Forward in _generic_edge_filter Remove superfluous mask argument from _generic_edge_filter Only report failure on main branch once Deprecate estimate method in favor of class constructor (scikit-image#7771) Temporary fix for Visual Studio & Clang incompatibility in Windows image (scikit-image#7835) Address deprecations in Pillow 11.3 (scikit-image#7828) Remove unused & obsolete `legacy_datasets`, `legacy_registry` vars (scikit-image#7677) Draft migration guide for skimage2 (scikit-image#7785) Do not report failure in wheels sub-recipe (scikit-image#7806) Use consistent wording in property description. (scikit-image#7804) Add intensity_median to regionprops (scikit-image#7745) CI: Update pypa/gh-action-pypi-publish to v1.12.4 for attestations on PyPI (scikit-image#7793) Document output dtype for transform.resize. (scikit-image#7792) Use `cibuildwheel` to build WASM/Pyodide wheels for `scikit-image`, push nightlies to Anaconda.org (scikit-image#7440) DOC: Include missing gain parameter in adjust_gamma equation (scikit-image#7763) Temporarily pin to `pyodide-build==0.30.0`, and ensure that the correct xbuildenvs are used (scikit-image#7788) Deprecate old names & attributes in RegionProperties (scikit-image#7778) ...
4 participants
Closes #7821
Recent MSVC STL templates need Clang 19.
Quoting from:
actions/runner-images#12435 (comment)
"The visual studio version was upgraded to MSVC 17.14 which needs minimum clang
version of 19.1.5".