Skip to content

Comments

Pin JasonEtco/create-an-issue action to SHA for v2.9.2#7787

Merged
stefanv merged 1 commit intoscikit-image:mainfrom
stefanv:pin-create-an-issue-to-sha
May 2, 2025
Merged

Pin JasonEtco/create-an-issue action to SHA for v2.9.2#7787
stefanv merged 1 commit intoscikit-image:mainfrom
stefanv:pin-create-an-issue-to-sha

Conversation

@stefanv
Copy link
Member

@stefanv stefanv commented May 1, 2025

/cc @lagru

@jarrodmillman jarrodmillman added the 🔧 type: Maintenance Refactoring and maintenance of internals label May 2, 2025
@stefanv stefanv merged commit 2425584 into scikit-image:main May 2, 2025
24 of 26 checks passed
@stefanv stefanv added this to the 0.26 milestone May 2, 2025
steps:
- name: "Job has failed: reporting"
uses: JasonEtco/create-an-issue@v2
uses: JasonEtco/create-an-issue@1b14a70e4d8dc185e5cc76d3bec9eab20257b2c5 # v2.9.2
Copy link
Member

@lagru lagru May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for commenting so late after the fact. But I still think its good to check.

This action is placed after creation of the wheels and before deploy via wheels-test-and-release.yaml. I know the if: ${{ ... && contains(needs.*.result, 'failure') }} should prevent it from running for successful releases.

But if we ever change that or there's a bug we increase our exposure during releases. Do we trust this action enough to integrate it that closely with our critical release workflow?

matthew-brett added a commit to matthew-brett/scikit-image that referenced this pull request Jul 7, 2025
* origin/main:
  Deprecate estimate method in favor of class constructor (scikit-image#7771)
  Temporary fix for Visual Studio & Clang incompatibility in Windows image (scikit-image#7835)
  Address deprecations in Pillow 11.3 (scikit-image#7828)
  Remove unused & obsolete `legacy_datasets`, `legacy_registry` vars (scikit-image#7677)
  Draft migration guide for skimage2 (scikit-image#7785)
  Do not report failure in wheels sub-recipe (scikit-image#7806)
  Use consistent wording in property description. (scikit-image#7804)
  Add intensity_median to regionprops (scikit-image#7745)
  CI: Update pypa/gh-action-pypi-publish to v1.12.4 for attestations on PyPI (scikit-image#7793)
  Document output dtype for transform.resize. (scikit-image#7792)
  Use `cibuildwheel` to build WASM/Pyodide wheels for `scikit-image`, push nightlies to Anaconda.org (scikit-image#7440)
  DOC: Include missing gain parameter in adjust_gamma equation (scikit-image#7763)
  Temporarily pin to `pyodide-build==0.30.0`, and ensure that the correct xbuildenvs are used (scikit-image#7788)
  Deprecate old names & attributes in RegionProperties (scikit-image#7778)
  Pin JasonEtco/create-an-issue action to SHA for v2.9.2 (scikit-image#7787)
  Make doctest-plus work with spin (scikit-image#7786)
  Report failures on main via issue (scikit-image#7752)
  Use `workers` instead of alternate parameter names (scikit-image#7302)
  Fix f-string in otsu plot (scikit-image#7780)
  Further document use of regionprops function and fix terms. (scikit-image#7518)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔧 type: Maintenance Refactoring and maintenance of internals

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants