Skip to content

Comments

Update import convention in certain gallery examples#7764

Merged
lagru merged 7 commits intoscikit-image:mainfrom
AlexLouk:new-import-convention
Jul 9, 2025
Merged

Update import convention in certain gallery examples#7764
lagru merged 7 commits intoscikit-image:mainfrom
AlexLouk:new-import-convention

Conversation

@AlexLouk
Copy link
Contributor

@AlexLouk AlexLouk commented Mar 27, 2025

Description

This PR changes some of the examples old import convention for the new one (import skimage as ski)
Addresses parts of #7454.

Checklist

Release note

For maintainers and optionally contributors, please refer to the instructions on how to document this PR for the release notes.

...

@mkcor mkcor added the 📄 type: Documentation Updates, fixes and additions to documentation label Mar 27, 2025
@mkcor mkcor changed the title Swaped old import convention in examples for new one Swapped old import convention in examples for new one Mar 27, 2025
@AlexLouk
Copy link
Contributor Author

@mkcor do I need to do something to fix the failed checks ?

@mkcor
Copy link
Member

mkcor commented Mar 27, 2025

@AlexLouk seeing no failed checks at the moment 😉

Copy link
Member

@mkcor mkcor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much, @AlexLouk! I apologize for the late review. I have left two suggestions which are not directly related to the issue, but I'm taking the opportunity of this PR to fix minor stylistic inconsistencies. Also, feel free to update your branch (i.e., sync up with main)!

Copy link
Member

@mkcor mkcor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @AlexLouk!

In other places, I've changed cmap=plt.cm.gray into the simpler cmap="gray" but I won't require it here.

Copy link
Member

@lagru lagru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AlexLouk. :)

@lagru lagru linked an issue Jul 9, 2025 that may be closed by this pull request
@lagru lagru changed the title Swapped old import convention in examples for new one Update import convention in example gallery Jul 9, 2025
@lagru lagru changed the title Update import convention in example gallery Update import convention in gallery examples Jul 9, 2025
@lagru lagru changed the title Update import convention in gallery examples Update import convention in certain gallery examples Jul 9, 2025
@lagru lagru merged commit 591c296 into scikit-image:main Jul 9, 2025
24 checks passed
@stefanv stefanv added this to the 0.26 milestone Jul 9, 2025
matthew-brett added a commit to matthew-brett/scikit-image that referenced this pull request Jul 11, 2025
* origin/main:
  Update import convention in certain gallery examples (scikit-image#7764)
  Refactor fundamental matrix scaling (scikit-image#7767)
matthew-brett added a commit to matthew-brett/scikit-image that referenced this pull request Jul 14, 2025
* origin/main: (31 commits)
  Update import convention in certain gallery examples (scikit-image#7764)
  Refactor fundamental matrix scaling (scikit-image#7767)
  Add unit test for cval unequal to zero
  Forward  in _generic_edge_filter
  Remove superfluous mask argument from _generic_edge_filter
  Only report failure on main branch once
  Deprecate estimate method in favor of class constructor (scikit-image#7771)
  Temporary fix for Visual Studio & Clang incompatibility in Windows image (scikit-image#7835)
  Address deprecations in Pillow 11.3 (scikit-image#7828)
  Remove unused & obsolete `legacy_datasets`, `legacy_registry` vars (scikit-image#7677)
  Draft migration guide for skimage2 (scikit-image#7785)
  Do not report failure in wheels sub-recipe (scikit-image#7806)
  Use consistent wording in property description. (scikit-image#7804)
  Add intensity_median to regionprops (scikit-image#7745)
  CI: Update pypa/gh-action-pypi-publish to v1.12.4 for attestations on PyPI (scikit-image#7793)
  Document output dtype for transform.resize. (scikit-image#7792)
  Use `cibuildwheel` to build WASM/Pyodide wheels for `scikit-image`, push nightlies to Anaconda.org (scikit-image#7440)
  DOC: Include missing gain parameter in adjust_gamma equation (scikit-image#7763)
  Temporarily pin to `pyodide-build==0.30.0`, and ensure that the correct xbuildenvs are used (scikit-image#7788)
  Deprecate old names & attributes in RegionProperties (scikit-image#7778)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📄 type: Documentation Updates, fixes and additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gallery examples use old import convention.

4 participants