Reenable graph reproducibility test#7694
Merged
jarrodmillman merged 1 commit intoscikit-image:mainfrom Feb 3, 2025
Merged
Conversation
matthew-brett
added
the
🤖 type: Infrastructure
matthew-brett
force-pushed
the
test-flaky-repo-test
branch
from
12a57b1 to
571f9c1
Compare
matthew-brett
changed the title
Contributor
Author
|
Test has passed a couple of times at least. Shall we merge and see how it goes? |
stefanv
approved these changes
Feb 3, 2025
stefanv
changed the title
jarrodmillman
changed the title
jarrodmillman
changed the title
jarrodmillman
changed the title
jarrodmillman
approved these changes
Feb 3, 2025
Member
|
When Jarrod just changed the name, I realized that Azure was 32-bit, and new platform is 64-bit. Maybe there's something specific to 32-bit that caused the problem? |
Contributor
Author
|
Ah - interesting - as far as I can see the Azure images were Windows Server 2022 - and I think that doesn't have a 32-bit version - they are all 64-bit. And the logs have x64 versions of Python. Are you sure about the 32-bit? |
Member
|
No, then probably not; just saw the win32 tag and wondered. |
Contributor
Author
|
Sorry - where is the win32 tag - is it in the logs somewhere? |
Member
|
In the diff of this PR |
Contributor
Author
|
Ah no - sorry - So - 64-bit operating system. And: |
matthew-brett
added a commit
to matthew-brett/scikit-image
that referenced
this pull request
Feb 4, 2025
…ailure * origin/main: Add zizmor to pre-commit; address GH workflow issues raised (scikit-image#7662) Reenable test marked as flaky on Azure. (scikit-image#7694) Simultaneously resolve all dependencies; add pip caching (scikit-image#7690) Copy keypoints if necessary to preserve contiguity (scikit-image#7692) CI cleanup (scikit-image#7693) Port CI testing from Azure to GitHub (scikit-image#7687) Lower CI build verbosity Use pytest config in pyproject.toml in CI (scikit-image#7555) Improve docstring for rolling_ball function. (scikit-image#7682)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reenable test marked as flaky; does it still fail (sometimes) on GHA?