Conversation
lagru
left a comment
lagru
left a comment
There was a problem hiding this comment.
Nice bit of cleaning up! 😊 Renaming and splitting also very much makes sense to me. Should make our CI way easier to parse.
Could even look into cleaning up https://github.com/scikit-image/scikit-image/actions once things have settled down.
There was a problem hiding this comment.
Makes sense and actually thought about suggesting that but I wasn't sure if there would be potential side effects. Didn't really find a overview but at least https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/creating-a-default-community-health-file and https://docs.github.com/en/actions/about-github-actions/understanding-github-actions imply there isn't.
There was a problem hiding this comment.
It seems to work OK, but if it causes trouble we can move it back out.
.github/workflows/test-docs.yaml
Outdated
| - name: Install test dependencies | ||
| run: | | ||
| source .github/scripts/setup_test_env.sh |
There was a problem hiding this comment.
Do we even need the test dependencies here?
There was a problem hiding this comment.
No, good point, I'll remove.
.github/workflows/test-macos.yaml
Outdated
| test_docs_aarch64: | ||
| name: macos-docs | ||
| runs-on: ubuntu-24.04-arm |
There was a problem hiding this comment.
Seems duplicate with test-docs.yaml. Did you forget to remove this?
There was a problem hiding this comment.
Yes, that was wrong; removed.
Yes! I was hoping you could help me with that, since I recall you doing it before. |
.github/workflows/test-docs.yaml
Outdated
| - name: Build docs / run examples | ||
| run: | | ||
| source .github/scripts/setup-docs-env.sh | ||
| SPHINXCACHE=${HOME}/.cache/sphinx SPHINXOPTS="-W -j auto" make -C doc html |
There was a problem hiding this comment.
Actually a small quality of life improvement:
| - name: Build docs / run examples | |
| run: | | |
| source .github/scripts/setup-docs-env.sh | |
| SPHINXCACHE=${HOME}/.cache/sphinx SPHINXOPTS="-W -j auto" make -C doc html | |
| - name: Install doc dependencies | |
| run: | | |
| source .github/scripts/setup-docs-env.sh | |
| - name: Build docs / run examples | |
| run: | | |
| SPHINXCACHE=${HOME}/.cache/sphinx SPHINXOPTS="-W -j auto" make -C doc html |
Should it somewhat easier to review sphinx output without scrolling through is pip's output before it that's mostly noise.
|
One more thing we should add to CI: caching. |
…ailure * origin/main: Add zizmor to pre-commit; address GH workflow issues raised (scikit-image#7662) Reenable test marked as flaky on Azure. (scikit-image#7694) Simultaneously resolve all dependencies; add pip caching (scikit-image#7690) Copy keypoints if necessary to preserve contiguity (scikit-image#7692) CI cleanup (scikit-image#7693) Port CI testing from Azure to GitHub (scikit-image#7687) Lower CI build verbosity Use pytest config in pyproject.toml in CI (scikit-image#7555) Improve docstring for rolling_ball function. (scikit-image#7682)
3 participants
This is hopefully the last of it:
.yamlinstead of.yml)..githubfolder.Also separate out docs build.