Skip to content

Copy keypoints if necessary to preserve contiguity#7692

Merged
jarrodmillman merged 4 commits intoscikit-image:mainfrom
stefanv:brief-copy-when-necessary
Feb 3, 2025
Merged

Copy keypoints if necessary to preserve contiguity#7692
jarrodmillman merged 4 commits intoscikit-image:mainfrom
stefanv:brief-copy-when-necessary

Conversation

@stefanv
Copy link
Member

@stefanv stefanv commented Jan 31, 2025

Closes #7685

@olebole would this suffice?

Release note

For maintainers and optionally contributors, please refer to the instructions on how to document this PR for the release notes.

In `skimage.feature.BRIEF`, copy `keypoints` if necessary to preserve contiguity.

@stefanv stefanv marked this pull request as ready for review January 31, 2025 23:03
@stefanv stefanv added the 🩹 type: Bug fix Fixes unexpected or incorrect behavior label Jan 31, 2025
Copy link
Member

@lagru lagru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the right approach.

@@ -1,3 +1,7 @@
Please include necessary information to complete each entry. The
release manager should be able to step through this file without
external references.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stefanv stefanv force-pushed the brief-copy-when-necessary branch from 20c2a5f to 825ba05 Compare February 3, 2025 02:52
@jarrodmillman jarrodmillman merged commit 7f104bd into scikit-image:main Feb 3, 2025
24 checks passed
matthew-brett added a commit to matthew-brett/scikit-image that referenced this pull request Feb 4, 2025
…ailure

* origin/main:
  Add zizmor to pre-commit; address GH workflow issues raised (scikit-image#7662)
  Reenable test marked as flaky on Azure. (scikit-image#7694)
  Simultaneously resolve all dependencies; add pip caching (scikit-image#7690)
  Copy keypoints if necessary to preserve contiguity (scikit-image#7692)
  CI cleanup (scikit-image#7693)
  Port CI testing from Azure to GitHub (scikit-image#7687)
  Lower CI build verbosity
  Use pytest config in pyproject.toml in CI (scikit-image#7555)
  Improve docstring for rolling_ball function. (scikit-image#7682)
@stefanv stefanv added this to the 0.25.2 milestone Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🩹 type: Bug fix Fixes unexpected or incorrect behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_brief failures on 32-bit platforms with numpy2

3 participants