Simultaneously resolve all dependencies; add pip caching#7690
Merged
jarrodmillman merged 2 commits intoscikit-image:mainfrom Feb 3, 2025
Merged
Simultaneously resolve all dependencies; add pip caching#7690jarrodmillman merged 2 commits intoscikit-image:mainfrom
jarrodmillman merged 2 commits intoscikit-image:mainfrom
Conversation
stefanv
force-pushed
the
resolve-all-requirements
branch
from
ae2b500 to
3494089
Compare
Member
|
Originally brought up in #7672 (comment). |
lagru
approved these changes
Jan 31, 2025
Member
lagru
left a comment
lagru
left a comment
There was a problem hiding this comment.
Thanks. Seems quite simple and elegant, though slightly wasteful to run this on every PR. Thought's on restricting this to main?
Member
Author
|
We should cache our pip dependencies, if we don't already; then it will cost almost nothing. |
stefanv
force-pushed
the
resolve-all-requirements
branch
from
3494089 to
c0fcf6c
Compare
stefanv
changed the title
jarrodmillman
approved these changes
Feb 3, 2025
matthew-brett
added a commit
to matthew-brett/scikit-image
that referenced
this pull request
Feb 4, 2025
…ailure * origin/main: Add zizmor to pre-commit; address GH workflow issues raised (scikit-image#7662) Reenable test marked as flaky on Azure. (scikit-image#7694) Simultaneously resolve all dependencies; add pip caching (scikit-image#7690) Copy keypoints if necessary to preserve contiguity (scikit-image#7692) CI cleanup (scikit-image#7693) Port CI testing from Azure to GitHub (scikit-image#7687) Lower CI build verbosity Use pytest config in pyproject.toml in CI (scikit-image#7555) Improve docstring for rolling_ball function. (scikit-image#7682)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lagru was concerned that, because of CI simplifications, we no longer simultaneously resolve all dependencies to see if they are compatible. This step aims to bring back that check.